New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seterrors should log as errors #485

Closed

jimmyhchan opened this issue Jun 26, 2014 · 0 comments · Fixed by #579

Contributor

jimmyhchan commented Jun 26, 2014

Now (v2.4) that we are no longer throwing an error when logging, please log errors when we chunk.setError and stream emit error

https://github.com/linkedin/dustjs/blob/master/lib/dust.js#L448
https://github.com/linkedin/dustjs/blob/master/lib/dust.js#L472

There may be other places as well.

not sure whether this should be logged as a warning or an error
https://github.com/linkedin/dustjs/blob/master/lib/dust.js#L359

sethkinast mentioned this issue

Clean up / refactor logging #579

Merged

prashn64 closed this as completed in #579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment