Clean up / refactor logging #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reduces logspew by ~600 lines |
| * Compile a template to an invokable function. | ||
| * If `name` is provided, also registers the template under `name`. | ||
| * @param source {String} template source | ||
| * @param name {String} template name |
There was a problem hiding this comment.
template name is optional. i think there's a jsdoc syntax for that @param [name] {string}
|
LOOKS good! |
sethkinast
force-pushed
the
log-language
branch
from
301544e to
c02b88d
Compare
|
Spew comparison: Old: https://travis-ci.org/linkedin/dustjs/jobs/55233215 |
| @@ -710,7 +677,6 @@ | |||
| } else if (skip) { | |||
| return skip(this, context); | |||
| } | |||
| dust.log('Not rendering exists (?) block in template [' + context.getTemplateName() + '], because above key was not found', DEBUG); | |||
There was a problem hiding this comment.
We may have to keep this one.
sethkinast
force-pushed
the
log-language
branch
from
7355bd8 to
0ac0c53
Compare
|
Updated with Prash's comments:
|
sethkinast
force-pushed
the
log-language
branch
from
0ac0c53 to
6302f25
Compare
sethkinast
force-pushed
the
log-language
branch
from
6302f25 to
6c1c968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to LinkedInAttic/dustjs-helpers#119
Normalizes all log messages, removes some spew, fixes some logs that would never be logged, and removes the indexOf shim in favor of a map lookup.
Closes #485