Issue #332 provide a raw input syntax similar to comments {!...!} where ... #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…..!} where newlines, spaces and braces are kept. should also address linkedin#238 and linkedin#265
|
This would also be useful if generating JSON objects to the output stream. No need to escape the braces. |
| @@ -1254,7 +1299,7 @@ var coreTests = [ | |||
| name: "error: whitespaces between the opening brace and any of (#,?,@,^,+,%) is not allowed", | |||
| source: '{ # helper foo="bar" boo="boo" } {/helper}', | |||
| context: { "helper": function(chunk, context, bodies, params) { return chunk.write(params.boo + " " + params.foo); } }, | |||
| error: 'Expected buffer, comment, partial, reference, section or special but "{" found. At line : 1, column : 1', | |||
| error: 'Expected buffer, comment, partial, raw, reference, section or special but "{" found. At line : 1, column : 1', | |||
There was a problem hiding this comment.
Did you update the error message in the grammar? I don't see this update.
| @@ -1240,6 +1282,9 @@ var coreTests = [ | |||
| } | |||
| ] | |||
| }, | |||
| /** | |||
| * CORE GRAMMER TESTS | |||
|
lgtm 👍 |
|
to keep master clean we should not pull this until after the 2.1 milestones bugs are merged. |
|
I think it's time we pulled this in. Jimmy, can you update your branch? |
|
Updated. Look: nothing changes in dist and package json stays at 2.2.3..... we'll do the bumps when we release the next version |
prashn64
added a commit
that referenced
this pull request
Dec 9, 2013
Issue #332 provide a raw input syntax similar to comments {!...!} where newlines, spaces and braces are kept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...newlines, spaces and braces are kept. should also address #238 and #265