Rhino unit tests #392
Merged
Rhino unit tests #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but we may want to do something in the Travis.yaml matrix so that it only runs once. Currently this is running for both node 0.10 and node 0.8. maybe have node latest run npm test and have other versions run npm testWithoutRhino.... not sure what's the best. see http://about.travis-ci.org/docs/user/build-configuration/#The-Build-Matrix |
|
By the same token I don't know if it makes sense to run phantom unit tests in both 0.10 and 0.8. Seems that one of them is enough. How about we run full set of unit tests (node, phantom and rhino) in 0.10 and only node unit tests in 0.8? |
|
Agreed good point |
jimmyhchan
added a commit
that referenced
this pull request
Jan 16, 2014
Add Rhino and Rhino unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to run unit tests in Rhino 1.7R3 and 1.7R5
Integrated with grunt so
grunt testwill run unit tests in Rhino as well. This will ensure that unit tests are ran in Rhino as part of Travis CI as well - issue #386.