Back compatible compiler #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| coreTests = require('./jasmine-test/spec/coreTests'), | ||
| coreSetup = require('./core').coreSetup; | ||
|
|
||
| //make dust a global |
There was a problem hiding this comment.
I'm not sure how the changes in this file relate to this PR. Were these changes included intentionally?
There was a problem hiding this comment.
This was intentional change for 2.2.x branch. Unit tests with server.js were broken there. So fixing them as part of this commit as well. Now all of the unit tests pass (node test/server.js, node test/jasmine-test/server/specRunner.js and running jasmine client SpecRunner.html in a browser).
I've also added comments in server.js, so merging up to 2.3.x also shows up as few changes there.
|
I believe you need to go back to the 2.2.6 branch and generate the dist files. |
|
ok, makes sense to me. code looks good. |
|
Looks good to me. |
prashn64
added a commit
that referenced
this pull request
Feb 12, 2014
Make the compiler backwards compatible with runtime versions prior to 2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Dust 2.2.0 we've introduced backward incompatible change to the compiler (using
Context.prototype._getinstead ofContext.prototype.getandContext.prototype.getPath)._getmethod was added to Dust 2.2.0 runtime. With that change, templates compiled in 2.2.0 and newer can not be rendered with Dust runtimes prior to 2.2.0.This pull request makes sure that older Dust runtimes (before 2.2.0) can render templates compiled with Dust 2.2.6 and beyond and 2.3.4 and beyond.
I am switching compiler from
_gettoget. This way older runtimes will use old implementation ofgetmethod. Newer runtimes will use new implementation ofgetmethod which calls_getunder the hood.Patching 2.2.x and 2.3.x versions