remove support for context.isFunction #438
Conversation
| @@ -378,7 +378,6 @@ | |||
| return dust.log(err, ERROR); | |||
| } | |||
| }; | |||
| fn.isFunction = true; | |||
| return fn; | |||
There was a problem hiding this comment.
Is there a reason to define fn variable? Could we do:
return function() {
...
};
There was a problem hiding this comment.
Yeah, this function can be simplified down to that now.
|
Looks good to me. How are we documenting or announcing this deprecation? |
|
That's actually up for discussion. I'm against polluting the console.log window, unless you can get rid of the message by fixing your code. There's no way to do that in this situation. One place where it will be documented is the Changelog.MD. That might be good enough, but we can also just have a section in the README. I think this would be pretty useful to update as you release a new version, since then you can go back to older tags and see exactly what is/was being deprecated/removed within that release. Let me know what you guys think about that. |
|
Having a deprecated/removed section by release in the README seems like a good backup to the Changelog.MD. Not everyone looks at the Changelog so repeating ourselves regarding things going away seems worth the small extra effort. Putting in deprecated in release n makes it easy to copy the line to "removed" in release n+1. |
|
Updated to not include the merge commit: #447 |
No description provided.