New dustc compiler #545
Merged
New dustc compiler #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethkinast
force-pushed
the
dustc
branch
5 times, most recently
from
32220e5 to
f8bb854
Compare
|
lgtm, let's get one more set of eyes on it. |
| args = args.filter(function(arg) { | ||
| var match = arg.match(ARG_REGEX), | ||
| val; | ||
| cli.setUsage(cli.app + ' [options] [path1 [path2 path3...]]\n\n' + |
There was a problem hiding this comment.
--Is this an API change. No back compat?--
I think I see the options below.. nvm
There was a problem hiding this comment.
Yep, new compiler. Had to kill the old syntax to allow it to work like a shell script.
dustc input output doesn't work anymore.
That's why I waited for a new minor version.
|
👍 looks good. small comments. Good stuff. Thanks! |
prashn64
added a commit
that referenced
this pull request
Mar 5, 2015
New dustc compiler. This breaks backward compat, but allows streaming output and a usage manual. Also includes tests that were nonexistent previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #536 so it's a branch off that branch. That means that #536 changes appear in this PR; however there are only changes to
dustcin this branch.I also added a unit test suite to cover
dustc, since we previously had no test coverage on the command-line compiler.