Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IPv6-enabled proxy-init #12249

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Use IPv6-enabled proxy-init #12249

merged 3 commits into from
Apr 2, 2024

Conversation

alpeb
Copy link
Member

@alpeb alpeb commented Mar 12, 2024

Followup to linkerd/linkerd2-proxy-init#350

  • For the linkerd-control-plane chart added the values.yaml entry disableIPv6, defaulting to false.
  • For the linkerd2-cni chart added the entries iptablesMode (defaults to "legacy") and disableIPv6 (defaults to false).

Note this allows routing IPv6 traffic to the proxy by default, but it's just the first step towards IPv6/dual-stack support. More control plane and proxy changes will come next.

@alpeb alpeb requested a review from a team as a code owner March 12, 2024 17:47
@alpeb alpeb force-pushed the alpeb/ip6tables branch 3 times, most recently from c15bbfb to 1ab3eca Compare March 13, 2024 12:47
@alpeb alpeb changed the title Use IPv6-enabled proxy-init WIP: Use IPv6-enabled proxy-init Mar 13, 2024
@alpeb alpeb force-pushed the alpeb/ip6tables branch 4 times, most recently from 1f5600c to b2c819e Compare March 13, 2024 14:53
@alpeb alpeb changed the title WIP: Use IPv6-enabled proxy-init Use IPv6-enabled proxy-init Mar 13, 2024
- For the linkerd-control-plane chart added the values.yaml entry `disableIPv6`, defaulting to false. If we wan't to explicitly set `disableIPv6=true`, the proxy-init v2.3.0 (containing linkerd/linkerd2-proxy-init#350) needs to be used, otherwise proxy-init will error out because of the unknown flag.
- For the linkerd2-cni chart added the entries `iptablesMode` (defaults to "legacy") and `disableIPv6` (defaults to false). These flags can still be passed to the current proxy-init version (without  linkerd/linkerd2-proxy-init#350) and will simply be ignored.

Note this allows routing IPv6 traffic to the proxy by default, but it's just the first step towards IPv6/dual-stack support. More control plane and proxy changes will come next.
@alpeb alpeb force-pushed the alpeb/ip6tables branch from b2c819e to 45f2782 Compare March 19, 2024 22:45
@alpeb
Copy link
Member Author

alpeb commented Mar 20, 2024

I've refactored this so that it remains fully compatible the current proxy-init (v2.2.4) and updated the description above accordingly.

@olix0r olix0r marked this pull request as draft March 22, 2024 15:40
@alpeb alpeb marked this pull request as ready for review April 2, 2024 12:33
@alpeb alpeb merged commit 7ec3f8e into main Apr 2, 2024
48 checks passed
@alpeb alpeb deleted the alpeb/ip6tables branch April 2, 2024 17:25
the-wondersmith pushed a commit to the-wondersmith/linkerd2 that referenced this pull request Apr 24, 2024
Followup to linkerd/linkerd2-proxy-init#350

- For the linkerd-control-plane chart added the values.yaml entry `disableIPv6`, defaulting to false.
- For the linkerd2-cni chart added the entries `iptablesMode` (defaults to "legacy") and `disableIPv6` (defaults to false).

Note this allows routing IPv6 traffic to the proxy by default, but it's just the first step towards IPv6/dual-stack support. More control plane and proxy changes will come next.

Co-authored-by: Oliver Gould <[email protected]>
Signed-off-by: Mark S <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants