-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace actions/checkout with actions/upload/download #3602
Replace actions/checkout with actions/upload/download #3602
Conversation
d10c3c2
to
d323155
Compare
@siggy this is ready for review. I've removed all the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome to see this!
i wouldn't worry too much about the repetition. we already have a lot of that. eventually we could move the repeated bits into their own actions, or wait for yaml anchor support.
the current test failure looks related to a dirty repo.
browsing through a couple stack overflow questions, it sounds like copying a git repo is not a great idea. instead, we could just tar and upload the .git
directory, download it to a temp location (i think {{ runner.temp }}
or $RUNNER_TEMP
will work?), and then git clone {{ runner.temp }} {{ github.workspace }}
@siggy this is ready for review again. The tests were green! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excited to see this, great work! ✅ ✅ ✅
Signed-off-by: Alejandro Pedraza Borrero <[email protected]>
Notes for reviewers: This replaces the multiple calls to Ever other job depends on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this 👍.
So far just a test, please don't review