[feat] linode placement groups - boilerplate + controllers + e2e tests #414
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 67.50% 66.65% -0.85%
==========================================
Files 42 47 +5
Lines 2625 2912 +287
==========================================
+ Hits 1772 1941 +169
- Misses 746 850 +104
- Partials 107 121 +14 ☔ View full report in Codecov by Sentry. |
|
@tchinmai7 This generally looks fine though I'm curious how this new CRD was generated. Did you use kubebuilder? I don't see the PROJECT file updated to account for the new CRD. |
I had manually added the types and ran generate - I'll fix the project file and other stuff to be more |
tchinmai7
changed the title
|
since we are in the middle of migrating from v1alpha1 to v1alpha2, could we potentially just add this directly to v1alpha2? |
sure - I can do that |
PROJECT
Outdated
| domain: cluster.x-k8s.io | ||
| group: infrastructure | ||
| kind: LinodePlacementGroup | ||
| path: github.com/linode/cluster-api-provider-linode/api/v1alpha1 |
There was a problem hiding this comment.
after the v1alpha2 move we want to update these as well
| } | ||
|
|
||
| if pg != nil { | ||
| if len(pg.Members) > 0 { |
There was a problem hiding this comment.
could we potentially move this into it's own function to remove the nestif exception?
What this PR does / why we need it:
Adds controllers and boilerplate for linode placement groups - introduces the types, web-hooks, controllers and e2e tests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This doesn't have any integration with
LinodeMachineorLinodeClusteryet - will put up a follow up PR for implementing that. For now, this can create and manage a linode placement group.TODOs: