Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add a v1alpha2 version of LinodeMachine #416

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

eljohnson92
Copy link
Collaborator

What this PR does / why we need it:
This PR adds LinodeMachine to the v1alpha2 version
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@eljohnson92 eljohnson92 force-pushed the linodemachine_v1alpha2 branch 2 times, most recently from b23beab to 4503cab Compare July 22, 2024 13:52
@eljohnson92 eljohnson92 force-pushed the linodemachine_v1alpha2 branch from 4503cab to 5f0dac5 Compare July 22, 2024 14:13
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 83.52273% with 29 lines in your changes missing coverage. Please review.

Project coverage is 67.61%. Comparing base (8746ec1) to head (f88bd46).
Report is 1 commits behind head on main.

Files Patch % Lines
api/v1alpha2/linodemachine_webhook.go 73.97% 17 Missing and 2 partials ⚠️
api/v1alpha1/linodemachine_conversion.go 95.45% 2 Missing and 2 partials ⚠️
api/v1alpha2/linodemachine_types.go 33.33% 4 Missing ⚠️
api/v1alpha2/linodemachine_conversion.go 0.00% 1 Missing ⚠️
controller/linodemachine_controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   66.65%   67.61%   +0.96%     
==========================================
  Files          47       51       +4     
  Lines        2912     3085     +173     
==========================================
+ Hits         1941     2086     +145     
- Misses        850      874      +24     
- Partials      121      125       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 merged commit 907e6bf into main Jul 22, 2024
15 checks passed
@eljohnson92 eljohnson92 deleted the linodemachine_v1alpha2 branch July 22, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants