Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add PlacementGroupRef to linodeMachine #418

Merged
merged 16 commits into from
Jul 28, 2024
Merged

Conversation

tchinmai7
Copy link
Contributor

@tchinmai7 tchinmai7 commented Jul 19, 2024

What this PR does / why we need it:

  1. Adds a placementGroupRef to the linodeMachine controller
  2. bump linodego to 1.38
  3. fix placementgroup api breaking change

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. To test this, add the following to the generated manifest ( the placementGroupRef and LinodePlacementGroup)
---
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha2
kind: LinodeMachineTemplate
metadata:
  name: schinmai-test-control-plane
  namespace: default
spec:
  template:
    spec:
      authorizedKeys: null
      image: linode/ubuntu22.04
      interfaces:
      - purpose: public
      placementGroupRef:
        apiVersion: infrastructure.cluster.x-k8s.io/v1alpha2
        kind: LinodePlacementGroup
        name: schinmai-test
      region: us-ord
      type: g6-standard-2
---
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha2
kind: LinodePlacementGroup
metadata:
  name: schinmai-test
  namespace: default
spec:
  region: us-ord
---

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.15%. Comparing base (fbb370a) to head (18e939b).

Files Patch % Lines
controller/linodemachine_controller_helpers.go 59.25% 7 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   66.03%   66.15%   +0.11%     
==========================================
  Files          64       64              
  Lines        3336     3365      +29     
==========================================
+ Hits         2203     2226      +23     
- Misses        974      977       +3     
- Partials      159      162       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 changed the title saving progress [feat] Add PlacementGroupRef Jul 20, 2024
@tchinmai7 tchinmai7 changed the title [feat] Add PlacementGroupRef [feat] Add PlacementGroupRef to linodeMachine Jul 23, 2024
@tchinmai7 tchinmai7 marked this pull request as ready for review July 23, 2024 19:49
@tchinmai7 tchinmai7 marked this pull request as draft July 23, 2024 22:32
AshleyDumaine
AshleyDumaine previously approved these changes Jul 24, 2024
@tchinmai7 tchinmai7 marked this pull request as ready for review July 26, 2024 21:32
@tchinmai7 tchinmai7 merged commit 4e620d5 into main Jul 28, 2024
17 of 18 checks passed
@tchinmai7 tchinmai7 deleted the pg-linodemachine branch July 28, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants