Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add v1alpha2 of linodeVPC #421

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[feat] add v1alpha2 of linodeVPC #421

merged 1 commit into from
Jul 23, 2024

Conversation

eljohnson92
Copy link
Collaborator

What this PR does / why we need it:
This PR adds v1alpha2 of linodeVPC and cleans up old v1alpha1 references in code and templates
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 79.39698% with 41 lines in your changes missing coverage. Please review.

Project coverage is 68.56%. Comparing base (64ff32a) to head (77e7c9b).

Files Patch % Lines
api/v1alpha2/linodevpc_webhook.go 84.67% 17 Missing and 2 partials ⚠️
controller/linodevpc_controller.go 56.25% 6 Missing and 1 partial ⚠️
api/v1alpha1/linodevpc_conversion.go 90.47% 2 Missing and 2 partials ⚠️
api/v1alpha2/linodevpc_types.go 33.33% 4 Missing ⚠️
controller/linodemachine_controller.go 0.00% 4 Missing ⚠️
controller/linodemachine_controller_helpers.go 50.00% 2 Missing ⚠️
api/v1alpha2/linodevpc_conversion.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   67.72%   68.56%   +0.83%     
==========================================
  Files          51       55       +4     
  Lines        3151     3324     +173     
==========================================
+ Hits         2134     2279     +145     
- Misses        889      913      +24     
- Partials      128      132       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 force-pushed the vpc_v1alpha2 branch 2 times, most recently from 4e09a67 to 721078f Compare July 23, 2024 17:29
@eljohnson92 eljohnson92 merged commit f66718b into main Jul 23, 2024
18 checks passed
@eljohnson92 eljohnson92 deleted the vpc_v1alpha2 branch July 23, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants