Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add support for disk encryption #423

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[feat] add support for disk encryption #423

merged 2 commits into from
Jul 29, 2024

Conversation

AshleyDumaine
Copy link
Contributor

@AshleyDumaine AshleyDumaine commented Jul 24, 2024

What this PR does / why we need it: LDE was released as of the latest linodego release. This allows for that feature to be used (if available via a webhook check) for LinodeMachines.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation <-- still need this
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.65%. Comparing base (0095cc6) to head (a4db46a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   64.65%   64.65%           
=======================================
  Files          68       68           
  Lines        3517     3517           
=======================================
  Hits         2274     2274           
  Misses       1061     1061           
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshleyDumaine AshleyDumaine changed the title [feat] add support for disk encryption if the capability is present [feat] add support for disk encryption Jul 29, 2024
@AshleyDumaine AshleyDumaine marked this pull request as ready for review July 29, 2024 17:56
@AshleyDumaine AshleyDumaine merged commit 3119045 into main Jul 29, 2024
13 checks passed
@AshleyDumaine AshleyDumaine deleted the disk-encryption branch July 29, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants