Fix LKE shuffled node pool diffing #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBGarber
force-pushed
the
fix-shuffled-np-diff
branch
2 times, most recently
from
95a7ff0 to
7e067b9
Compare
LBGarber
force-pushed
the
fix-shuffled-np-diff
branch
from
7e067b9 to
98183f0
Compare
0xch4z
suggested changes
Jul 21, 2021
LBGarber
force-pushed
the
fix-shuffled-np-diff
branch
from
bd7dfc3 to
d7dd7ab
Compare
0xch4z
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests addresses an intermittent non-empty diff on the
TestAccLinodeLKECluster_poolUpdatesacceptance test. As the Linode API does not guarantee the order of returned node pools, we must adapt the returned node pool list to best match the schema configuration.Currently this cannot be achieved using a DiffSuppressFunc, so the API response must be sorted in the read routine.
See: hashicorp/terraform-plugin-sdk#477