Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta-lxatac-software: python3-labgrid: use SRCREV from meta-labgrid #197

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

hnez
Copy link
Member

@hnez hnez commented Oct 23, 2024

PR #195 should have updated the labgrid version used to the one configured in meta-labgrid.
Instead it only updated the recipe (and dropped the dependency for autobahn etc.), so we currently have a labgrid version installed that still depends on autobahn, but with dependencies for a grpc based labgrid version.

This results in labgrid-exporter.service failing to start:

Traceback (most recent call last):
  File "/usr/bin/labgrid-exporter", line 5, in <module>
    from labgrid.remote.exporter import main
  File "/usr/lib/python3.12/site-packages/labgrid/remote/exporter.py", line 19, in <module>
    from autobahn.asyncio.wamp import ApplicationRunner, ApplicationSession
ModuleNotFoundError: No module named 'autobahn'

Fix that by actually using the SRCREV from meta-labgrid.

Commit e3b9c26 should have updated the labgrid version used to the one
configured in meta-labgrid.
Instead it only updated the recipe (and dropped the dependency for
autobahn etc.), so we currently have a labgrid version installed that
still depends on autobahn, but with dependencies for a grpc based labgrid
version.
This results in `labgrid-exporter.service` failing to start:

    Traceback (most recent call last):
      File "/usr/bin/labgrid-exporter", line 5, in <module>
        from labgrid.remote.exporter import main
      File "/usr/lib/python3.12/site-packages/labgrid/remote/exporter.py", line 19, in <module>
        from autobahn.asyncio.wamp import ApplicationRunner, ApplicationSession
    ModuleNotFoundError: No module named 'autobahn'

Fix that by _actually_ using the SRCREV from meta-labgrid.

Fixes: e3b9c26 ("meta-labgrid: update to a version that adds grpc support")
Signed-off-by: Leonard Göhrs <[email protected]>
@hnez hnez requested a review from jluebbe October 23, 2024 11:52
@jluebbe jluebbe merged commit 19bcaa4 into linux-automation:scarthgap Oct 23, 2024
4 checks passed
@hnez hnez deleted the labgrid-grpc-fix branch October 23, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants