-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta-lxatac-software: panel-mipi-dbi: cleanups for upstreaming #199
Conversation
The upstream project did not have a release yet (the SRCREV we use is indeed only the second commit in the repository). Indicate that with a `_git` version suffix. Signed-off-by: Leonard Göhrs <[email protected]>
The `python3` shebang has been mainlined, so there is no need to carry it locally anymore. This is the only change in this update. Signed-off-by: Leonard Göhrs <[email protected]>
Update `SUMMARY`, `DESCRIPTION`, `HOMEPAGE` and `SECTION` in preparation to mainlining of the recipe to meta-openembedded. Signed-off-by: Leonard Göhrs <[email protected]>
Make the class more usable to the general public in preparation to mainlining to meta-openembedded. Signed-off-by: Leonard Göhrs <[email protected]>
…s doc The `panel-mipi-dbi.bbclass` documentation has the `inherit` at the top of the file so we should do so as well. Signed-off-by: Leonard Göhrs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine to me.
Two additional note on the class:
For meta-oe master
I guess PANEL_FIRMWARE
needs to be looked up in UNPACKDIR
rather than in WORKDIR
.
I'd also suggest placing the output of do_compile()
into B
instead of WORKDIR
.
According to the Variable glossary[1] `B` is: The directory within the Build Directory in which the OpenEmbedded build system places generated objects during a recipe’s build process. [1]: https://docs.yoctoproject.org/ref-manual/variables.html#term-B Signed-off-by: Leonard Göhrs <[email protected]>
That makes sense, thanks. meta-lxatac/meta-lxatac-software/classes/panel-mipi-dbi.bbclass Lines 36 to 40 in 7e1b5ba
Oh, yes, thanks! Updated as well. |
We want to upstream the
panel-mipi-dbi
class and-native
recipes (as part of internal task number 050.441).I think openembedded/meta-openembedded would be a good fit for such a upstreaming effort.
These are some cleanups to the recipes before making the first upstreaming attempt.
Feel free to be extra strict now, so no one is going to be mean to me on the mailing list.