Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson #28

Merged
merged 6 commits into from
Apr 9, 2024
Merged

meson #28

merged 6 commits into from
Apr 9, 2024

Conversation

konradybcio
Copy link
Member

also pkgconfig, some format fixes

include/meson.build Outdated Show resolved Hide resolved
Copy link
Member

@superna9999 superna9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash patch 2 into 2, and squash lib: generate pkgconfig patch into 1 also, otherwise looks good

'-Wcast-align',
'-Wlogical-op',
'-Wjump-misses-init']
endif
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I start to hate such lists. What was the reason for selecting -Wfoo but not -Wbar? Can we just set -Wall instead? Or -Wall -Wextra?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbf, I copypasted it from cdba..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I use warning_level=everything from meson instead?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to stick to -Wall. And in CDBA too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meson.build Outdated Show resolved Hide resolved
src/lookup.c Outdated Show resolved Hide resolved
@lumag
Copy link

lumag commented Apr 9, 2024 via email

meson.build Outdated Show resolved Hide resolved
@lumag
Copy link

lumag commented Apr 9, 2024

Nit: it would be nice to make qrtr-ns optional and maybe even skip it by default in the followup.

@konradybcio
Copy link
Member Author

Nit: it would be nice to make qrtr-ns optional and maybe even skip it by default in the followup.

that was my idea for the next pr.. and then a new tagged release right after it - sounds good?

@lumag
Copy link

lumag commented Apr 9, 2024

SGTM

@konradybcio konradybcio merged commit 415736c into master Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants