-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson #28
meson #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash patch 2 into 2, and squash lib: generate pkgconfig
patch into 1 also, otherwise looks good
'-Wcast-align', | ||
'-Wlogical-op', | ||
'-Wjump-misses-init'] | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I start to hate such lists. What was the reason for selecting -Wfoo but not -Wbar? Can we just set -Wall instead? Or -Wall -Wextra?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbf, I copypasted it from cdba..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I use warning_level=everything
from meson instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to stick to -Wall. And in CDBA too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`systemd-unit-prefix`. And a default if the option is not specified.
|
Signed-off-by: Konrad Dybcio <[email protected]>
Nit: it would be nice to make qrtr-ns optional and maybe even skip it by default in the followup. |
that was my idea for the next pr.. and then a new tagged release right after it - sounds good? |
SGTM |
also pkgconfig, some format fixes