Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional parameters in uploadurl #5

Open
harshinim opened this issue Aug 23, 2016 · 7 comments
Open

Additional parameters in uploadurl #5

harshinim opened this issue Aug 23, 2016 · 7 comments

Comments

@harshinim
Copy link

Is it possible to send additional parameters to the uploadUrl? We specify uploadUrl at UploadManager , but the parameters I need to pass are specific for a file and hence would have been ideal if the url was specified for UploadHandler

@harshinim
Copy link
Author

I think in UploadManager, formData is taking only file as the parameter - should we modify it to read additional parameters and pass it in formData?

@harshinim
Copy link
Author

I got this working by using customized upload function and passing it to UploadHandler

@lionng429
Copy link
Owner

so is the upload props in UploadHandler sufficient for this?

@harshinim
Copy link
Author

yes , that's good enough, but I had to duplicate the whole method only to be able to pass the additional formData - May be we should enhance your code to accept additional parameters and pass it it. Let me know if I can contribute

lionng429 added a commit that referenced this issue Aug 23, 2016
@lionng429
Copy link
Owner

of course, it's my pleasure to have your contribution, as long as you don't mind the lack of CI configs and incomplete test cases.

I pushed a draft 8860a13 and see if that's what you want?

@harshinim
Copy link
Author

Yes, this is exactly what I wanted - Thanks, I am going to try it and see how it works

@lionng429
Copy link
Owner

@harshinim no problem. Please be aware that is not released yet. you may need to refer the source to github rather than just doing npm install. It would be better to release with test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants