Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrapper existence check in Receiver constructor #18

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

lionng429
Copy link
Owner

@lionng429 lionng429 commented Mar 27, 2018

it('should not throw if wrapperId is given and element elements having that id exists', () => {
    expect(() => mount(
        <div id="customId">
          <Receiver
            wrapperId="customId"
            onDragEnter={emptyFn}
            onDragOver={emptyFn}
            onDragLeave={emptyFn}
            onFileDrop={emptyFn}
          />
        </div>
    )).not.toThrow();
});

- as mentioned in #17, wrapper existence check does not work for wrapperId pointing to Receiver's parent wrapper. Moving the logic back to componentDidMount solves this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant