expose some superagent options as properties for UploadManager #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t method instead of post
…t method instead of post
…urn json - send the file directly using super agent send without form data
… form data - expose the file field name
|
@digital-flowers Thanks for your PR. could you please make changes on just the files in |
|
i saw many react libraries include the lib files in the source code so some users can do npm install directly from github what do you think ?! |
lionng429
added a commit
that referenced
this pull request
Mar 22, 2018
- added `reqConfigs` as a prop which accepts `accept`, `method`, `timeout` and `withCredentials` properties - added `formDataParser` as a prop which allows custom fields to be sent through in the request - referred to the suggestions in #9
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was testing your component with azure cloud Shared Access Signature (SAS) and i faced some problems and i solved them as follow:
1- add
methodproperty default aspost, some cloud storage required put instead of post2- add
acceptproperty default asapplication/json, if response doesn't return json for example using cloud SAS this property can cause a problem3- add
fieldname property default tofile, when user use cloud SAS user can set property to null to send the file without form4- set request
typefromfile.type