-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAT-18141 changes for liquibase-checks extension #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jnewton03
commented
Jul 24, 2024
- utilize matrix.os for build and test
… step for macOS runners to support Docker setup ♻️ (.github/workflows/pro-extension-test.yml): Refactor the way extraMavenArgs are passed to the Maven command to ensure proper handling of spaces and special characters
…ut to specify if built jars should be combined into a single jar 🔧 (pro-extension-test.yml): create a new job 'Combine Jars' to download artifacts from different platforms and create a multiplatform jar if 'combineJars' input is true
…eps for macOS 🔧 (pro-extension-test.yml): update conditional logic for running tests based on nightly flag and OS type to improve workflow efficiency
…nts for running tests to ensure correct logic 🔧 (.github/workflows/pro-extension-test.yml): Add ls command to list files in /tmp directory for debugging purposes
…th' to specify the path to the module that should be built. This is useful for multi-module extensions. 🔧 (.github/workflows/pro-extension-test.yml): Update working directory for various steps to use the 'modulePath' input value.
…s.extraMavenArgs to prevent shell expansion and ensure correct arguments are passed to Maven commands
…ency from 'combineJars' job to improve workflow efficiency
…use project version for artifact naming and handling
…mes for consistency and readability 🔧 (pro-extension-test.yml): add quotes around the expression in the maven command to handle cases where the expression contains special characters
…en command by adding missing closing parenthesis
…st files in /tmp directory for debugging purposes
…pdate references to use the correct output variable 🔧 (pro-extension-test.yml): update artifact naming to include the correct artifact version for consistency and clarity 🔧 (pro-extension-test.yml): update download paths to use the correct artifact version for each platform 🔧 (pro-extension-test.yml): refactor creating multiplatform jar to use a more concise and efficient method
…rsion to avoid redundancy and improve workflow efficiency
…able name to correctly reference artifact version in workflow steps
…ations to simplify workflow steps 🔧 (pro-extension-test.yml): separate download artifacts steps for Ubuntu, macOS, and Windows to improve clarity and organization 🔧 (pro-extension-test.yml): refactor artifact handling to create separate directories for Linux, Windows, and macOS artifacts and generate a combined artifact for liquibase checks
…ng steps and update directory creation and extraction steps to improve workflow efficiency
…to remove directories 🔧 (pro-extension-test.yml): fix incorrect directory name in 'rm' command to remove liquibase-checks 🔧 (pro-extension-test.yml): fix incorrect file path in 'cat' command to combine fileslist.txt 🔧 (pro-extension-test.yml): fix incorrect directory name in 'zip' command to create liquibase-checks jar
… liquibase-checks directory and files to ensure proper file operations and artifact creation.
…to use /tmp folder for creating multiplatform jar to avoid conflicts with existing files and improve organization.
…ist contents of /tmp directory for troubleshooting purposes
…ineJars option to specify combining jars into one for artifact release workflow 🔧 (.github/workflows/pro-extension-test.yml): remove redundant working-directory settings in job steps to improve workflow readability 🔧 (.github/workflows/pro-extension-test.yml): update paths to combine artifacts based on the operating system for better organization and clarity
…h input and update artifactPath to include target directory for artifacts gathering. Update working-directory for Get Artifact ID and Get Artifact Version steps to use artifactPath instead of modulePath. Update path for Save Artifacts step to include target directory. Update path for Save Event File and Save Multiplatform Artifacts steps to include all files in the specified artifactPath.
…input fields for os, extraMavenArgs, and artifactPath to provide more flexibility and customization options for the workflow.
…javadoc, and pom files for multiplatform artifacts in the build process.
…tifacts step to prevent unnecessary execution and speed up the workflow.
…h to artifacts for multi-module extensions 🔧 (extension-release-published.yml): Add support for specifying the path to artifacts for multi-module extensions 🔧 (extension-release-rollback.yml): Add support for specifying the path to artifacts for multi-module extensions
…ob to include working-directory for better organization and clarity 🔧 (extension-release-published.yml): update Get Artifact ID and Publish to Maven Central jobs to include working-directory for consistency and better organization
…-push.yml to DAT-18141 and add support for specifying the artifact path 🔧 (.github/workflows/sonar-push.yml): Add support for specifying the artifact path to be attached to the build
…clude all files with the same prefix for better flexibility 🔧 (pro-extension-test.yml): Update artifact path to include all files with the same prefix for better flexibility
… files in the specified directory 🔧 (pro-extension-test.yml): Update path to include all files in the specified directory
…clude specific jar, sources jar, javadoc jar, and pom files for release attachment 🔧 (pro-extension-test.yml): Update artifact path to include specific jar, sources jar, javadoc jar, and pom files for testing purposes
… in artifact attachment step to prevent errors 🐛 (pro-extension-test.yml): Remove duplicate file path in artifact attachment step to prevent errors
…on for combining jars during release artifact build to simplify workflow and improve clarity
…he specified artifact path before building release artifacts
…fact copying to simplify and improve readability 🔧 (pro-extension-test.yml): Update file paths for artifact copying to simplify and improve readability
…neJars job to ensure unit tests are run before combining jars
…ude checkModificationExcludeList and ignoreSnapshots options for release preparation.
…oad and build steps as they are not needed for the current workflow and can be re-enabled if required in the future.
…nd download artifacts from GPM and build release artifacts 🔧 (extension-release-prepare.yml): Update workflow to prepare Maven release with correct arguments 🔧 (extension-release-published.yml): Update workflow to build release artifacts with correct arguments 🔧 (extension-release-rollback.yml): Update workflow to perform Maven release rollback with correct arguments
…he specified artifact path before signing files for draft release
…e to improve script readability and maintainability
…n to run extra command in the specified path 🔧 (extension-release-published.yml): Add working directory configuration to run extra command in the specified path 🔧 (extension-release-rollback.yml): Add working directory configuration to run extra command in the specified path 🔧 (sonar-pull-request.yml): Add working directory configuration to run extra command in the specified path 🔧 (sonar-push.yml): Add working directory configuration to run extra command in the specified path
… by using absolute path from REPO_ROOT to target directory
…ownload to use the input variable for flexibility 🔧 (extension-attach-artifact-release.yml): update the working directory for attaching files to the draft release to the specified artifact path 🔧 (extension-attach-artifact-release.yml): update the command to run the upload script with the correct path to the project root folder
…he specified artifact path before setting draft release title
…nclude inputs.artifactPath for signing artifacts correctly
…for the output file path instead of hardcoding it to improve flexibility and reusability
…main' branch instead of a specific commit hash for better maintainability ⬆️ (extension-release-prepare.yml): Update extension-release-rollback.yml reference to use the 'main' branch instead of a specific commit hash for better maintainability ⬆️ (pro-extension-test.yml): Update sonar-pull-request.yml reference to use the 'main' branch instead of a specific commit hash for better maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.