Skip to content

Commit

Permalink
Revert "Only update peer with the first and last block (hyperledger#5659
Browse files Browse the repository at this point in the history
)"

This reverts commit 048ddf4.
  • Loading branch information
davidkngo authored Jul 21, 2023
1 parent a92d1d2 commit 9f96bce
Showing 1 changed file with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,8 @@ protected Optional<List<BlockHeader>> processResponse(
BlockHeader prevBlockHeader = firstHeader;
updatePeerChainState(peer, firstHeader);
final int expectedDelta = reverse ? -(skip + 1) : (skip + 1);
BlockHeader header = null;
for (int i = 1; i < headers.size(); i++) {
header = headers.get(i);
final BlockHeader header = headers.get(i);
if (header.getNumber() != prevBlockHeader.getNumber() + expectedDelta) {
// Skip doesn't match, this isn't our data
LOG.debug("header not matching the expected number. Peer: {}", peer);
Expand All @@ -117,11 +116,6 @@ protected Optional<List<BlockHeader>> processResponse(
}
prevBlockHeader = header;
headersList.add(header);
}
// if we have received more than one header we have to update the chain state with the last
// header as well, as the header with the highest block number can be the first or the last
// header.
if (headers.size() > 1) {
updatePeerChainState(peer, header);
}

Expand Down

0 comments on commit 9f96bce

Please sign in to comment.