Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lsp for V programming language #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

RohanVashisht1234
Copy link
Contributor

No description provided.

Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifest indentation seems to be wrong.

I'm not too sure about using a beta LSP server.


local installed_path = USERDIR .. PATHSEP .. "plugins" .. PATHSEP .. "lsp_v"

lspconfig.v_lsp.setup(common.merge({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lspconfig.v_lsp is not a thing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like even with this fixed, you still need a working install of V.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! I just forgot about this pr. sorry, I'll fix this and think about it.

@RohanVashisht1234
Copy link
Contributor Author

ok gman, changes have been made

Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still isn't enough, as v-analyzer requires a V install to work properly.
See custom_vroot here.

@RohanVashisht1234
Copy link
Contributor Author

So what exactly needs to be done here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants