Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely revamped the litmusctl workflow #16

Merged
merged 23 commits into from
Jul 8, 2021

Conversation

imrajdas
Copy link
Member

@imrajdas imrajdas commented Jul 6, 2021

Changes

  1. BCH score moved from 5 to 7
    Selection_232

  2. Refactored most of the functions and code to accommodate the new commands

  3. Improved Code quality. Now sonarcube grade is A

  4. Adding interactive and non-interactive mode

Commands

  1. litmusctl config
    a) set-account example- litmusctl config set-account --endpoint "https://litmus.preview.chaosnative.com" --password "" --username "raj"
    b) get-accounts example- litmusctl config get-accounts
    c) use-account example- litmusctl config use-account --endpoint "https://litmus.preview.chaosnative.com" -u "raj"
    d) view example-litmusctl config view

  2. litmusctl create
    a) agent example- litmusctl create agent --agent-name "raj-new-agent" --cluster-type "external" --installation-mode "cluster" --platform-name "AWS" --sa-exists=false --ns-exists=false --project-id "" -n

Minimal step to create agent

`litmusctl create agent --agent-name "new-agent"

b) project example- litmusctl create project --name ""

  1. litmusctl get
    a) projects example- litmusctl get projects
    b) agents example- litmusctl get agents --project-id

imrajdas added 15 commits June 30, 2021 03:34
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
Signed-off-by: Raj Das <[email protected]>
@imrajdas imrajdas requested review from Jonsy13 and arkajyotiMukherjee and removed request for Jonsy13 July 6, 2021 23:53
Signed-off-by: Raj Das <[email protected]>
@imrajdas imrajdas force-pushed the rewrite-litmusctl branch from ad12174 to efdcc4a Compare July 6, 2021 23:53
@imrajdas imrajdas requested a review from ajeshbaby July 6, 2021 23:54
@imrajdas
Copy link
Member Author

imrajdas commented Jul 7, 2021

Please ignore the lint issue(will fix it soon in this Pr). @Jonsy13 / @arkajyotiMukherjee can you guys do a review

Copy link
Contributor

@arkajyotiMukherjee arkajyotiMukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition. This is very good

README.md Outdated Show resolved Hide resolved
imrajdas added 3 commits July 7, 2021 21:07
@imrajdas imrajdas force-pushed the rewrite-litmusctl branch 3 times, most recently from 7f6a1c4 to 751cd5f Compare July 7, 2021 17:30
Signed-off-by: Raj Das <[email protected]>
pkg/agent/ops.go Outdated Show resolved Hide resolved
pkg/agent/ops.go Outdated Show resolved Hide resolved
Copy link
Contributor

@arkajyotiMukherjee arkajyotiMukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes 🚀

@imrajdas imrajdas force-pushed the rewrite-litmusctl branch from 871c4a6 to fd35ef4 Compare July 8, 2021 06:56
pkg/agent/ops.go Outdated
return "namespace"
}

if mode != 1 || mode != 2 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a reviewdog error here...can you check that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Raj Das <[email protected]>
Copy link
Contributor

@arkajyotiMukherjee arkajyotiMukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍🏼

@imrajdas imrajdas merged commit 72546de into litmuschaos:master Jul 8, 2021
@imrajdas imrajdas deleted the rewrite-litmusctl branch July 12, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants