Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use statement explicit #2

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Make use statement explicit #2

merged 1 commit into from
Nov 14, 2023

Conversation

kylewillmon
Copy link
Contributor

The current code does not compile with Rust 1.71.0

error[E0659]: `ctr` is ambiguous
 --> src/lib.rs:9:5
  |
9 | use ctr::Ctr;
  |     ^^^ ambiguous name
  |
  = note: ambiguous because of multiple potential import sources
  = note: `ctr` could refer to a crate passed with `--extern`
  = help: use `::ctr` to refer to this crate unambiguously
note: `ctr` could also refer to the module defined here
 --> src/lib.rs:7:1
  |
7 | mod ctr;
  | ^^^^^^^^
  = help: use `crate::ctr` to refer to this module unambiguously

For more information about this error, try `rustc --explain E0659`.
error: could not compile `aead-gcm-stream` (lib) due to previous error

This patch disambiguates the use statement for Rust versions before 1.72.0 (See the rust PR here)

Disambiguate the use statement for Rust versions before 1.72.0
Copy link
Owner

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@littledivy littledivy merged commit 37e6d48 into littledivy:main Nov 14, 2023
1 check passed
@kylewillmon kylewillmon deleted the explicit-use branch November 14, 2023 20:24
@kylewillmon
Copy link
Contributor Author

Can this be published in a release?

@littledivy
Copy link
Owner

Released 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants