New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve keycode merging #221

Merged

liuchengxu merged 1 commit into liuchengxu:master from rene-descartes2021:keycodes-improvement

Oct 25, 2022

Collaborator

rene-descartes2021 commented Aug 17, 2022 •

edited

Loading

Rather than list specific cases <Tab> <Space>, I think it better to generalize.

This PR proposes a way to generalize the mapping of keycodes to internal data-structures (description dictionary, native cache).

Also a couple other improvements:

Improved regex escaping in s:has_children()
Improved loop in s:wait_with_timeout(), there was a 20ms window before the timeout where if the user pressed a key in that timespan it would be considered not pressed.


          Improve keycode merging

0d8fd08

rene-descartes2021 marked this pull request as ready for review

August 17, 2022 17:24

liuchengxu merged commit 9875bae into liuchengxu:master

Owner

liuchengxu commented Oct 25, 2022

Sorry for the late merge, great work! 🍻

rene-descartes2021 deleted the keycodes-improvement branch

October 26, 2022 21:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet