Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native fallback bug introduced by 35078eca #229

Conversation

rene-descartes2021
Copy link
Collaborator

@rene-descartes2021 rene-descartes2021 commented Dec 5, 2022

Changes:

  • Fixes a problem introduced by 35078ec, where g:which_key_fallback_to_native_key no longer worked.
  • Adds documentation for g:which_key_ignore_invalid_key clarifying that it only has effect when g:which_key_fallback_to_native_key = 0.
  • s:which_key_trigger substitution improved, will handle spaces better in s:execute_native_fallback().

@rene-descartes2021 rene-descartes2021 force-pushed the native_trigger_fix branch 2 times, most recently from cffe030 to 60dbf5d Compare December 6, 2022 19:34
@rene-descartes2021 rene-descartes2021 changed the title Fix native fallback and keycode merge bugs Fix native fallback bug introduced by 35078eca Dec 6, 2022
@rene-descartes2021 rene-descartes2021 marked this pull request as ready for review December 6, 2022 20:18
@rene-descartes2021 rene-descartes2021 deleted the native_trigger_fix branch December 7, 2022 15:40
@rene-descartes2021
Copy link
Collaborator Author

rene-descartes2021 commented Dec 7, 2022

Interesting, accidentally didn't rebase this one before pushing to master and github doesn't show this PR (commit 72973ce) as merged but it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant