Remove redundant loop in s:getchar() #232
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rene-descartes2021
force-pushed
the
s-getchar-fix
branch
from
319b1ab to
0b3b433
Compare
rene-descartes2021
force-pushed
the
s-getchar-fix
branch
from
0b3b433 to
2c615f4
Compare
liuchengxu
added a commit
that referenced
this pull request
Aug 10, 2023
Part of #232, Thanks to @rene-descartes2021
liuchengxu
reviewed
Aug 10, 2023
| @@ -272,17 +261,14 @@ function! s:getchar() abort | |||
| return '<CR>' | |||
| endif | |||
|
|
|||
| let input .= which_key#char_handler#parse_raw(c) | |||
| if s:has_children(input) | |||
There was a problem hiding this comment.
This loop was introduced to distinguish the mappings like gc and gcc as initially reported in #3, I guess it's still useful.
There was a problem hiding this comment.
Oh ok I wasn't completely sure what was going on so I left this as a draft till I could figure things out better.
| endif | ||
| endwhile | ||
| let c = which_key#char_handler#parse_raw(c) | ||
| if has_key(s:KEYCODES, c) |
There was a problem hiding this comment.
This change has been incorporated into #240, thank you!
There was a problem hiding this comment.
Sounds good!
liuchengxu
added a commit
that referenced
this pull request
Aug 13, 2023
* Convert "\<Tab>" to "<Tab>" The mapping `<Tab>` is tracked in the mappings in String form, while the returned value from `getchar()` is a Number, convert it to String manually so that the corresponding entry in `s:runtime` can be retrieved. Close #135 * Handle more special keys properly Part of #232, Thanks to @rene-descartes2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
s:getchar()pathway, appears the loop there is redundant and erroneous. Redundant with respect to thewait_for_input()->s:handle_input()->s:show_next_level_mappings()recursion which progressively refiness:runtimewith:s:getchar()accumulates an input longer than one character, as the followingcall s:handle_input(get(s:runtime, char))will error as there is no key in s:runtime longer than one character. I'm not sure how this bug doesn't appear to surface, and I suspect that the loop isn't ever entered, but I could be wrong.