Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact mode fixes #10

Closed
lizsugar opened this issue May 25, 2022 · 2 comments
Closed

Compact mode fixes #10

lizsugar opened this issue May 25, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@lizsugar
Copy link
Owner

lizsugar commented May 25, 2022

The minimum height of the card in compact mode needs to be adjusted so that it remains uniform when both the icon and the action button are not visible:

Snapshot - 2022-25-5-15-24-56

The label should take up as much space as possible when icon and button are disabled. There is no reason for it to truncate that early:

image

@lizsugar lizsugar added the bug Something isn't working label May 25, 2022
@lizsugar lizsugar added this to the Release v2.0.0 milestone May 27, 2022
@lizsugar lizsugar changed the title Compact mode height inconsistent Compact mode fixes May 27, 2022
lizsugar added a commit that referenced this issue May 27, 2022
lizsugar added a commit that referenced this issue May 27, 2022
@lizsugar
Copy link
Owner Author

lizsugar commented May 27, 2022

Resolved the text width issue:

image

Resolve the height issue:
image

but discovered a bug that's existed for a while now:
Hiding the icon also hides the state when the card is not wide enough, as demonstrated in these two screenshots.

@lizsugar
Copy link
Owner Author

lizsugar commented May 28, 2022

Okay alignment issues should all be fixed

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant