Fix pyyaml dependency #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that pyup and pyyaml has anomalous versions and has become buggy. We fix this dependency by having pyup ignore such changes. PyYAML is only used for our logging configs, so this will not be harmful. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
added
bug
|
I'll override this for a while, @whzup and @SioKCronin , just to have a quick fix for this bottleneck that's causing us a lot of PR errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that pyup and pyyaml has anomalous versions and
has become buggy. We fix this dependency by having pyup ignore
such changes. PyYAML is only used for our logging configs, so
this will not be harmful.
Signed-off-by: Lester James V. Miranda [email protected]