Add reporter module #227
Merged
Add reporter module #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljvmiranda921
added
enhancement
This commit adds a reporter module that implements a Reporter class. Its goal is to separate the concern of logging and printing from the optimizer classes. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
force-pushed
the
add-reporter-module
branch
from
933b335 to
286623b
Compare
|
This looks pretty cool! Does this also work with |
9 tasks
Yup! |
whzup
approved these changes
Aug 19, 2018
Merged
ljvmiranda921
added a commit
that referenced
this pull request
Jan 29, 2019
Resolves #209 This commit adds a reporter module that implements a Reporter class. Its goal is to separate the concern of logging and printing from the optimizer classes. Signed-off-by: Lester James V. Miranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new module,
reporter, that handles all logging and printing actions. I also added a fancy progress bar c/otqdm(also part ofReportermethods).Related Issue
Resolves: #209
Motivation and Context
The
console_utilsmodule is severely outdated and needs refactoring. It's also better to separate the concern of logging and printing from theSwarmOptimizermodules. Just get aReporterinstance, and pass all necessary arguments.How Has This Been Tested?
No new tests, but it passes current test cases in
tests/Types of changes
Checklist:
Demonstration:
In a REPL:
In a Jupyter notebook cell:
