Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPRINT: Update general optimizer #244

Merged
merged 6 commits into from
Sep 12, 2018
Merged

SPRINT: Update general optimizer #244

merged 6 commits into from
Sep 12, 2018

Conversation

ljvmiranda921
Copy link
Owner

Change topology API so that GeneralOptimizer will only have one consistent API call

@ljvmiranda921 ljvmiranda921 added admin System-related and potential overrides refactor Better code quality, idiomatic Python labels Sep 12, 2018
@ljvmiranda921 ljvmiranda921 added this to the Refactor Sprint 11/15 milestone Sep 12, 2018
@ljvmiranda921 ljvmiranda921 self-assigned this Sep 12, 2018
@ljvmiranda921
Copy link
Owner Author

One thing I'm planning to do is have all options such as p, k, and r be required during initialization itself, rather than being called in compute_gbest(). These values do not change (except the number of neighbors in VonNeumann, but that can easily be handled), so there's no problem setting them as attributes.

@ljvmiranda921 ljvmiranda921 merged commit 0d2b11c into refactor-code-sprint Sep 12, 2018
@ljvmiranda921 ljvmiranda921 deleted the sprint-general-opt branch September 12, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ljvmiranda921 ljvmiranda921

Labels
admin System-related and potential overrides refactor Better code quality, idiomatic Python
Projects
None yet
Milestone
Refactor Sprint 11/15
Development

Successfully merging this pull request may close these issues.
1 participant
@ljvmiranda921