Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how dependencies are created #263

Merged
merged 6 commits into from
Jan 29, 2019
Merged

Conversation

ljvmiranda921
Copy link
Owner

Now, we're using pip-tools as a way to manage all our dependencies. We need to set it up first using an .in file, then compile it via make requirements.txt or make requirements-dev.txt. In this manner, all dependencies for the project are pinned explicitly.

Reference: #262

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ljvmiranda921 ljvmiranda921 added enhancement Feature requests v.1.1.0 In pipeline for next version labels Jan 28, 2019
@ljvmiranda921 ljvmiranda921 self-assigned this Jan 28, 2019
@ljvmiranda921 ljvmiranda921 requested a review from whzup January 28, 2019 16:01
For modern python, let's support py35 above

Signed-off-by: Lester James V. Miranda <[email protected]>
@ljvmiranda921
Copy link
Owner Author

matplotlib==3.0.2, the version we actually need, cannot be installed in py34. Let's remove support for that!

@ljvmiranda921 ljvmiranda921 merged commit 6fd11e4 into development Jan 29, 2019
@ljvmiranda921 ljvmiranda921 deleted the update/builds branch January 29, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests v.1.1.0 In pipeline for next version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant