Fix handlers #286
Merged
Fix handlers #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the BoundaryHandler would not handle the positions correctly because its memory wasn't populated.
Added newlines for the reflective strategy.
whzup
added
bug
|
Let me work on this on the weekend, thanks for the quick fix @whzup! |
ljvmiranda921
approved these changes
Feb 14, 2019
| @@ -177,13 +177,14 @@ def reflective(self, position, bounds, **kwargs): | |||
| :nowrap: | |||
|
|
|||
| \begin{gather*} | |||
| \text{while } x_{i, t, d} \not\in \left[lb_d,\,ub_d\right] \text{ do the | |||
| following:} | |||
| \text{while } x_{i, t, d} \not\in \left[lb_d,\,ub_d\right] \\ | |||
There was a problem hiding this comment.
Hmm, I didn't see this. Can you give me visual confirmation if this will render properly once generated?
(Just generate the docs and screenshot what this will look like)
|
Note to self: Merge on master and tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The memory of the
BoundaryHandlerin the Optimizers are now populated before the optimization loop starts. This prevents the Optimizers from generating positions that are out of the bounds in the first two iterations.Also added newlines for the documentation of the "reflective" strategy because I forgot them.
Related Issue
Resolves #285
Motivation and Context
See the issue.
How Has This Been Tested?
Ran the test.
Types of changes
Checklist: