-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optimise methods returning incorrect best_pos #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to see a PR of you, @ichbinjakes!👍🎊💯 There are some things that I think could be made easier (see comments in the code).
This seems good to me 👍 Thank you for your PR @ichbinjakes. Hope you had fun working on it 😄🎊 |
Can you squash-merge this, @whzup ? Thank you @ichbinjakes ! |
Nice!! Thank you again, @ichbinjakes , and to @whzup for conducting the review! I'll be updating the contributor's list this weekend! |
@allcontributors[bot] please add @ichbinjakes for bug and code |
I've put up a pull request to add @ichbinjakes! 🎉 |
Description of changes
Fix:
best_pos
best_pos
best_pos
best_pos
Tests:
Flake8 / Black reformatted some other code
Related Issue
#321
Motivation and Context
Bug fix
How Has This Been Tested?
Tested using unittest, then "ported' to the pytest files. All test passed.
Followed instruction in contributing.rst, except used new conda env.
Screenshots (if appropriate):
Types of changes
Checklist: