Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export palette in Write activity pop at the wrong place #807

Closed
llaske opened this issue May 24, 2020 · 5 comments
Closed

Export palette in Write activity pop at the wrong place #807

llaske opened this issue May 24, 2020 · 5 comments
Labels
bug to be release Fixed, to be release
Milestone

Comments

@llaske
Copy link
Owner

llaske commented May 24, 2020

Steps to reproduce:

  • Launch Write activity with the Export palette not visible (because the screen is too small)
  • Resize the screen to view the Export palette
  • Click on the Export palette, it's displayed at the left of the screen

Peek 24-05-2020 17-06

@llaske llaske added the bug label May 24, 2020
@prakashujjwal1010
Copy link
Contributor

Well, I found this bug not only in write activity but also in other activities.
this bug is occuring because the updatePosition for palette is not getting called on every click for toolbuttons.
see the code from palette.js of sugar-web library

invoker.addEventListener('click', function (event) { if (!that.invoker.classList.contains("toolbutton")) { updatePosition(event.x, event.y); } that.toggle(); });

Solution

we can change the code of palette.js to
invoker.addEventListener('click', function (event) { if (!that.invoker.classList.contains("toolbutton")) { updatePosition(event.x, event.y); } else { updatePosition(); } that.toggle(); });

so just wants to ask is there any problem in changing sugar-web lib code And should we change it in other activities also?

@quozl
Copy link

quozl commented May 27, 2020

If you fix it please also do so in https://github.com/sugarlabs/sugar-web

@llaske
Copy link
Owner Author

llaske commented May 28, 2020

Hmmm. First send a PR for Write, then we could extend it to sugar-web in all activities.
Which activities have you tested?

prakashujjwal1010 added a commit to prakashujjwal1010/sugarizer that referenced this issue May 28, 2020
@prakashujjwal1010
Copy link
Contributor

I have tested Paint activity , Physics activity, constellation
see below for physics activity,
ezgif com-video-to-gif (13)

basically it will occur when the palette's position or display property gets changed.

@llaske
Copy link
Owner Author

llaske commented Jun 3, 2020

Fixed in #808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

3 participants