Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong poll is displayed in Vote activity #854

Closed
llaske opened this issue Sep 23, 2020 · 3 comments
Closed

Wrong poll is displayed in Vote activity #854

llaske opened this issue Sep 23, 2020 · 3 comments
Labels
bug to be release Fixed, to be release
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Sep 23, 2020

When there was some creation/remove of poll, it could happens that the wrong poll is displayed when clicking on it.

Steps to reproduce:

  • Create a new Vote instance
  • Add a new poll labeled 6
  • Add a new poll labeled 7
  • Remove poll labeled 6
  • Create a new poll labeled 8
  • Click on poll 8, the poll 7 is displayed instead
@llaske llaske added the bug label Sep 23, 2020
@llaske
Copy link
Owner Author

llaske commented Sep 23, 2020

@dhruvmisra I guess it's related to the unique id generated for the new poll, it should depend of the number of current poll count. So when a poll is removed then a new poll created it could reuse the same id.

@dhruvmisra
Copy link
Contributor

@llaske Yes you're right, the issue was caused due to the unique ID generated being not so unique. Added a PR to fix it.

llaske added a commit that referenced this issue Sep 23, 2020
[Issue #854] Fixed uniquie ID issue on Vote and Curriculum
@llaske llaske added the to be release Fixed, to be release label Sep 23, 2020
@llaske
Copy link
Owner Author

llaske commented Sep 23, 2020

Fixed in a6c461a

@llaske llaske added this to the v1.5 milestone Apr 26, 2021
@llaske llaske closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

2 participants