Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #416 #465

Merged
merged 8 commits into from
Dec 6, 2019
Merged

Fix Issue #416 #465

merged 8 commits into from
Dec 6, 2019

Conversation

AndreaGon
Copy link
Contributor

@AndreaGon AndreaGon commented Dec 5, 2019 •
edited
Loading

Blockrain Activity can now be set to fullscreen mode.

Fix416

Small screen mode:

Mobile

I have to put the unfullscreen button at the bottom of the activity when screen size is small as it overlaps with the activity container. Any thoughts?

@AndreaGon
Temporary file
4d78dac 
Will be deleted once the icons folder is created
@AndreaGon
Add button images
ba3fa9c 
This will be the images for the fullscreen/unfullscreen button.
@AndreaGon
Add button tags
2049602 
The button tags will be the fullscreen and unfullscreen button. The unfullscreen button will be hidden by default.
@AndreaGon
Add css for the buttons
7797d27 
The css will add the images for the fullscreen/unfullscreen button. I have to adjust the position of the unfullscreen button when the screen size is small as it overlaps with the activity.
@AndreaGon
Adjust the window size on fullscreen mode
ec4269b 
The main toolbar will be hidden to fit the re-adjusted window size inside the canvas. This will give the "fullscreen" mode
@FreddieN
Copy link
Contributor

FreddieN commented Dec 5, 2019

See here: https://i.imgur.com/q1UKRv8.mp4

@AndreaGon
Re-add CSS
66cd22f 
Added the css for buttons
@AndreaGon
Copy link
Contributor Author

I found the problem: I accidentally put the HTML data inside the activity.css file 😆 Can you please check if it's working now?

@FreddieN
Copy link
Contributor

FreddieN commented Dec 5, 2019

Thanks, I should have spotted that! It works perfectly now! :D

@llaske
Copy link
Owner

llaske commented Dec 5, 2019

There is an issue when doing fullscreen/unfullscreen. See capture below:

Peek 05-12-2019 21-46

I wonder also why this line is commented and if it's not a good idea to call the updateSizes() method when doing fullscreen/unfullscreen.

@AndreaGon
Update return to normal state
d9777be 
Changed the value of the canvas' top position to 55 px instead of 8.7%
@AndreaGon
Copy link
Contributor Author

I think I've fixed the issue in this new commit.

@llaske to answer your questions:

  1. The game.updateSizes(); line is already commented when I've started working on the project. When I tried removing the comment (to see what it does), the generated background disappears and the blocks float when the screen is resized.

  2. I did not call updateSizes() as it has the same effect as stated above when the screen is resized.

Picture for reference:
reason

@llaske
Copy link
Owner

llaske commented Dec 6, 2019

Perfectly works now. Thanks.

@llaske llaske merged commit 22f4d6b into llaske:master Dec 6, 2019
@llaske llaske mentioned this pull request Dec 6, 2019
Closed
@llaske
Copy link
Owner

llaske commented Dec 6, 2019

You've done a PR on the master branch instead of the dev branch 😞
I had to revert it manually. Could you recreate a PR with this fix on the dev branch.

@AndreaGon
Copy link
Contributor Author

Oh no, I'm so sorry. I will create a PR in dev branch.

This won't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreddieN FreddieN FreddieN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreaGon @FreddieN @llaske