Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fullscreen/unfullscreen mode for Stopwatch Activity #607

Merged
merged 6 commits into from
Feb 18, 2020
Merged

Add fullscreen/unfullscreen mode for Stopwatch Activity #607

merged 6 commits into from
Feb 18, 2020

Conversation

AndreaGon
Copy link
Contributor

This should fix #599

stopwatch

llaske
llaske requested changes Feb 14, 2020
View reviewed changes
Copy link
Owner

@llaske llaske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Just an issue on indentation.

activities/Stopwatch.activity/js/activity.js Outdated Show resolved Hide resolved
@llaske llaske merged commit 927e534 into llaske:dev Feb 18, 2020
@llaske
Copy link
Owner

llaske commented Feb 18, 2020

Good job. Thanks.

@llaske llaske mentioned this pull request Feb 18, 2020
Closed
5 tasks
@Swayamsvk Swayamsvk mentioned this pull request Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llaske llaske llaske approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreaGon @llaske