-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorial with localization added to stopwatch activity #636
Conversation
I don't think this fix supports other languages. |
Code for localization has been set up. Native Speakers will translate the messages. |
b1a038f
to
e7f7694
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start. See my comments below.
activities/Stopwatch.activity/lib/sugar-web/activity/activity.js
Outdated
Show resolved
Hide resolved
e7f7694
to
208a327
Compare
That's fine but something is wrong regarding the font/style used by popup. See for example this comparison with another tutorial: Plus, could you reorder items in steps array? The idea is too put at first the most important. So I guess it could be: start button, reinit, time laps, counter, remove button, add button, ... |
@ksraj123 I believe the styling problem still persist in the popup . |
@abhishektanwar I think bootstrap was overriding the line-height of popup title as well, fixed that. Apart from that they look the same to my eyes. |
Hmm I suggest to try to use bootstrap-tour.min.css instead of bootstrap-tour-standalone.min.css because the later already include bootstrap.min.css. It could the reason of the conflict. Could you also solve conflict related to PR merged since your last commit? |
@llaske suggested changes made and merge conflict resolved. Please review.
Issue fixed by overriding concerned conflicting properties of bootstrap |
c3a8902
to
74b091b
Compare
Nice. The UI issue is now fixed. BTW the localization doesn't work: the Sugarizer language settings is not used. |
@llaske Suggested change made, Localisation initialised. |
fixes #596