Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional date string format from fullcalendar #415

Merged
merged 3 commits into from
May 28, 2018
Merged

additional date string format from fullcalendar #415

merged 3 commits into from
May 28, 2018

Conversation

nstoik
Copy link
Contributor

@nstoik nstoik commented Mar 4, 2018

Fix for different date string format in fullcalendar ajax request.

FullCalendar.io is sending start and end times in the format of '%Y-%m-%dT%H:%M:%S' for certain requests in addition to '%Y-%m-%d'

Tested with FullCalendar 3.8.2

Fix for different date string format in fullcalendar ajax request.

Try use one additional string before failing.
@coveralls
Copy link

coveralls commented Mar 4, 2018

Coverage Status

Coverage increased (+0.04%) to 80.207% when pulling ffc01b2 on nstoik:fullcalendar-eventsource-url-fix into 9340f93 on llazzaro:develop.

@llazzaro
Copy link
Owner

Can you provide test data of the failing case? or if possible an unit test?
Thanks a lot!

@nstoik
Copy link
Contributor Author

nstoik commented May 24, 2018

Added a test for a failing case.

@llazzaro llazzaro merged commit b5b3215 into llazzaro:develop May 28, 2018
@llazzaro
Copy link
Owner

thanks!!

@nstoik nstoik deleted the fullcalendar-eventsource-url-fix branch May 28, 2018 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants