Remove deprecated scrapy utils #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the latest Scrapy 2.10.0 release this library is running into errors because
scrapy.utils.reqserhas been fully removed from Scrapy after being deprecated in 2.6.0. See deprecations/removals in 2.10.0Because this library has been stable for a while, I dropped support for Scrapy <2.6.0 since it seems safe to rely on previous versions of the library for compatibility with older versions of Scrapy and not try to maintain full backwards-compatibilty. If you'd rather add that back in I'm happy to update this.
Thanks for the review, happy to make any changes!