[HandshakeToFIRRTL] legalize top FIRRTL module to meet the def-before-use requirement #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
approved these changes
Jan 30, 2021
There was a problem hiding this comment.
Looks good to me, thanks for addressing this so quickly! I think with this change and #488, we can lower Handshake modules with a loop and a structured variable all the way to System Verilog.
mikeurbach
reviewed
Jan 30, 2021
| @@ -32,6 +32,13 @@ using ValueVectorList = std::vector<ValueVector>; | |||
| // Utils | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| static void legalizeFModule(FModuleOp moduleOp) { | |||
| std::vector<Operation *> connectOps; | |||
There was a problem hiding this comment.
Could this be an LLVM data structure like SmallVector or maybe SmallPtrSet?
lattner
approved these changes
Jan 30, 2021
| SmallVector<Operation *, 8> connectOps; | ||
| moduleOp.walk([&](ConnectOp op) { connectOps.push_back(op); }); | ||
| for (auto op : connectOps) | ||
| op->moveBefore(&moduleOp.front().back()); |
There was a problem hiding this comment.
I'd recommend moduleOp.getBodyBlock().back()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for issue #534. All ConnectOp in the top FIRRTL module are moved to the end for meeting the def-before-use requirement of FIRRTL dialect.