Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCFToCalyx] Lower floating point comparison logic fix #8131

Merged
merged 1 commit into from
Jan 25, 2025
Merged

[SCFToCalyx] Lower floating point comparison logic fix #8131

merged 1 commit into from
Jan 25, 2025

Conversation

jiahanxie353
Copy link
Contributor

This patch fixes the logic of assigning the write_en port of the cmpf_reg: it should be high when the input register is done.

@jiahanxie353 jiahanxie353 merged commit 0cea50e into llvm:main Jan 25, 2025
4 of 5 checks passed
@jiahanxie353 jiahanxie353 deleted the cmpf- branch January 25, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgyurgyik cgyurgyik cgyurgyik approved these changes

@mikeurbach mikeurbach Awaiting requested review from mikeurbach mikeurbach is a code owner

@mortbopet mortbopet Awaiting requested review from mortbopet mortbopet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiahanxie353 @cgyurgyik