Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for llvm/llvm-project#72255 #777

Merged
merged 1 commit into from
Nov 20, 2023
Merged

PR for llvm/llvm-project#72255 #777

merged 1 commit into from
Nov 20, 2023

Conversation

llvmbot
Copy link
Member

@llvmbot llvmbot commented Nov 15, 2023

…68233)

Fixes #68051.

Current implementation passes the number of `_AlignedStorage` objects
when it calls to `allocate` and the number of **bytes** on `deallocate`.
This only applies to allocations that allocate control block and the
storage together, i.e. `make_shared` and `allocate_shared`.

Found by ASan under Clang combined with `-fsized-deallocation`.

(cherry picked from commit f722db02d359e29ca001b78197ee1a275f8c3d7c)
@ldionne
Copy link
Member

ldionne commented Nov 15, 2023

Approved for cherry-picking.

@tru tru merged commit b5cbb35 into release/17.x Nov 20, 2023
1 check failed
@tru tru deleted the llvm-issue72255 branch November 20, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cherry-pick libc++ sized deallocation fix
4 participants