Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win release packaging: Don't try to use rpmalloc for 32-bit x86 #106969

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

zmodem
Copy link
Collaborator

@zmodem zmodem commented Sep 2, 2024

because that doesn't work (results in LINK : error LNK2001: unresolved external symbol malloc).
Based on the title of #91862 it was only intended for use in 64-bit builds.

Copy link
Member

@aganea aganea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, only 64-bit was intended initially.

@zmodem zmodem merged commit ef26afc into llvm:main Sep 2, 2024
9 checks passed
@zmodem
Copy link
Collaborator Author

zmodem commented Sep 2, 2024

/cherry-pick ef26afc

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Sep 2, 2024
…#106969)

because that doesn't work (results in `LINK : error LNK2001: unresolved
external symbol malloc`).
Based on the title of llvm#91862 it was only intended for use in 64-bit
builds.

(cherry picked from commit ef26afc)
@llvmbot
Copy link
Member

llvmbot commented Sep 2, 2024

/pull-request #106985

tru pushed a commit to llvmbot/llvm-project that referenced this pull request Sep 3, 2024
…#106969)

because that doesn't work (results in `LINK : error LNK2001: unresolved
external symbol malloc`).
Based on the title of llvm#91862 it was only intended for use in 64-bit
builds.

(cherry picked from commit ef26afc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants