Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb][Linux] Add Control Protection Fault signal #122917

Merged
merged 1 commit into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lldb/source/Plugins/Process/Utility/LinuxSignals.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
#ifndef SEGV_MTESERR
#define SEGV_MTESERR 9
#endif
#ifndef SEGV_CPERR
#define SEGV_CPERR 10
#endif

#define ADD_SIGCODE(signal_name, signal_value, code_name, code_value, ...) \
static_assert(signal_name == signal_value, \
Expand Down Expand Up @@ -82,6 +85,7 @@ void LinuxSignals::Reset() {
ADD_SIGCODE(SIGSEGV, 11, SEGV_BNDERR, 3, "failed address bounds checks", SignalCodePrintOption::Bounds);
ADD_SIGCODE(SIGSEGV, 11, SEGV_MTEAERR, 8, "async tag check fault");
ADD_SIGCODE(SIGSEGV, 11, SEGV_MTESERR, 9, "sync tag check fault", SignalCodePrintOption::Address);
ADD_SIGCODE(SIGSEGV, 11, SEGV_CPERR, 10, "control protection fault");
// Some platforms will occasionally send nonstandard spurious SI_KERNEL
// codes. One way to get this is via unaligned SIMD loads. Treat it as invalid address.
ADD_SIGCODE(SIGSEGV, 11, SI_KERNEL, 0x80, "invalid address", SignalCodePrintOption::Address);
Expand Down
22 changes: 22 additions & 0 deletions lldb/test/API/linux/aarch64/gcs/TestAArch64LinuxGCS.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,25 @@ def test_gcs_region(self):

# Note that we must let the debugee get killed here as it cannot exit
# cleanly if GCS was manually enabled.

@skipUnlessArch("aarch64")
@skipUnlessPlatform(["linux"])
def test_gcs_fault(self):
if not self.isAArch64GCS():
self.skipTest("Target must support GCS.")

self.build()
self.runCmd("file " + self.getBuildArtifact("a.out"), CURRENT_EXECUTABLE_SET)
self.runCmd("run", RUN_SUCCEEDED)

if self.process().GetState() == lldb.eStateExited:
self.fail("Test program failed to run.")

self.expect(
"thread list",
"Expected stopped by SIGSEGV.",
substrs=[
"stopped",
"stop reason = signal SIGSEGV: control protection fault",
],
)
17 changes: 16 additions & 1 deletion lldb/test/API/linux/aarch64/gcs/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,19 @@ unsigned long get_gcs_status() {
return mode;
}

void gcs_signal() {
// If we enabled GCS manually, then we could just return from main to generate
// a signal. However, if the C library enabled it, then we'd just exit
// normally. Assume the latter, and try to return to some bogus address to
// generate the signal.
__asm__ __volatile__(
// Corrupt the link register. This could be many numbers but 16 is a
// nicely aligned value that is unlikely to result in a fault because the
// PC is misaligned, which would hide the GCS fault.
"add x30, x30, #10\n"
"ret\n");
}

int main() {
if (!(getauxval(AT_HWCAP2) & HWCAP2_GCS))
return 1;
Expand All @@ -50,5 +63,7 @@ int main() {
}

// By now we should have one memory region where the GCS is stored.
return 0; // Set break point at this line.
gcs_signal(); // Set break point at this line.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previously added test_gcs_region will stop here and then kill the process instead of continuing. So it will work as it did before.


return 0;
}
Loading