Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builtins] Mark int_lib.h builtins as static #69305

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

trevyn
Copy link
Contributor

@trevyn trevyn commented Oct 17, 2023

Mark the following symbols as static to prevent duplicate definitions:

__builtin_ctz
__builtin_clz
__builtin_clzll
__builtin_sadd_overflow

Without these then all of these functions show up in all object files which include int_lib.h on Windows. This'll help prevent duplicate symbols by ensuring they're not exported.

See:

rust-lang/compiler-builtins#167
https://reviews.llvm.org/D34599

@trevyn trevyn changed the title Mark int_lib.h builtins as static [builtins] Mark int_lib.h builtins as static Oct 18, 2023
@trevyn
Copy link
Contributor Author

trevyn commented Oct 18, 2023

@compnerd Politely requesting review :)

@trevyn
Copy link
Contributor Author

trevyn commented Jan 19, 2024

ping @compnerd

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, nice catch!

@compnerd
Copy link
Member

@trevyn do you have commit access, or do you need this committed for you?

@trevyn
Copy link
Contributor Author

trevyn commented Jan 19, 2024

@compnerd I do not, please commit for me. Thanks!

@compnerd compnerd merged commit d1a2f11 into llvm:main Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants