Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update documents around the GCP runners #367

Merged
merged 4 commits into from
Jan 31, 2025
Merged

[CI] Update documents around the GCP runners #367

merged 4 commits into from
Jan 31, 2025
+346 −23

Conversation

Keenuts
Copy link
Contributor

@Keenuts Keenuts commented Jan 28, 2025 •
edited
Loading

This PR expands the documentation around GCP and the K8 cluster running linux/windows runners.

boomanaiden154
boomanaiden154 reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments (mostly nits).

This looks really awesome! Thank you very much for putting time into writing proper documentation.

premerge/architecture.md Outdated Show resolved Hide resolved
premerge/architecture.md Outdated Show resolved Hide resolved
premerge/architecture.md Outdated Show resolved Hide resolved
premerge/architecture.md Outdated Show resolved Hide resolved
premerge/architecture.md Outdated Show resolved Hide resolved
premerge/architecture.md Outdated Show resolved Hide resolved
premerge/cluster-management.md Show resolved Hide resolved
premerge/cluster-management.md Show resolved Hide resolved
premerge/cluster-management.md Outdated Show resolved Hide resolved
premerge/docs.md Outdated Show resolved Hide resolved
@Keenuts
Copy link
Contributor Author

Keenuts commented Jan 29, 2025

Thanks, feedback applied!

boomanaiden154
boomanaiden154 reviewed Jan 29, 2025
View reviewed changes
premerge/docs.md Outdated Show resolved Hide resolved
premerge/architecture.md Show resolved Hide resolved
premerge/architecture.md Outdated Show resolved Hide resolved
premerge/architecture.md Outdated Show resolved Hide resolved
premerge/cluster-management.md Show resolved Hide resolved
premerge/monitoring.md Outdated Show resolved Hide resolved
boomanaiden154
boomanaiden154 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

premerge/cluster-management.md Show resolved Hide resolved
premerge/architecture.md Outdated Show resolved Hide resolved
@Keenuts Keenuts merged commit 267ca50 into llvm:main Jan 31, 2025
2 checks passed
@Keenuts Keenuts deleted the gcp-docs branch January 31, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boomanaiden154 boomanaiden154 boomanaiden154 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keenuts @boomanaiden154